feat: add findLongestRecurringCycle algorithm

[abda-gaye]

Describe your change:

• Add an algorithm?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file.
• All new JavaScript files are placed inside an existing directory.
• All filenames use the UpperCamelCase (PascalCase) style.
  • Example: Problem026.js and Problem026.test.js are allowed.
• All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • Algorithm Description
• If this pull request resolves one or more open issues, then the commit message contains Fixes: #{$ISSUE_NO}

Algorithm Description

I have implemented a new algorithm in the Problem026.js file, along with a corresponding test file Problem026.test.js to ensure its functionality. This algorithm addresses the problem described in the following link: Project Euler Problem 26.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (ff314a2) to head (fd1d6e6).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
+ Coverage   84.76%   84.86%   +0.10%     
==========================================
  Files         378      380       +2     
  Lines       19742    19874     +132     
  Branches     2955     2978      +23     
==========================================
+ Hits        16735    16867     +132     
  Misses       3007     3007              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[abda-gaye]

add findLongestRecurringCycle algorithm with tests

[appgurueu]

The logic checks out. However:

• This also adds a solution for problem 27, which should be in a different PR.
• There are many redundant comments. There should probably be half as many comments, if not much fewer. To give just one example of a redundant comment, consider let maxCycleLength = 0 // Store the maximum cycle length found.
• The tests are also pretty repetitive. They should just use it.each.

[abda-gaye]

my function answers problem026 Le dim. 20 oct. 2024 à 18:19, Lamine Gaye ***@***.***> a écrit :

…

it looks like you don't want my participation thank you ciao Le dim. 20 oct. 2024 à 18:17, Lars Müller ***@***.***> a écrit : > ***@***.**** requested changes on this pull request. > > The logic checks out. However: > > - This also adds a solution for problem 27, which should be in a > different PR. > - There are *many* redundant comments. There should probably be half > as many comments, if not much fewer. To give just one example of a > redundant comment, consider let maxCycleLength = 0 // Store the > maximum cycle length found. > - The tests are also pretty repetitive. They should just use it.each. > > — > Reply to this email directly, view it on GitHub > <#1733 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AZGAU5LJLWFRNLPBAJLS62LZ4PXTVAVCNFSM6AAAAABQBXRF6GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBQGY2DSNBZGQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[appgurueu]

it looks like you don't want my participation thank you ciao

I'm not sure how you arrived at this conclusion. I reviewed your participation because I wouldn't want it to merge as-is yet.

[abda-gaye]

so give me the changes I need to make, I made 3 pull requests and since then I haven't seen a response, I even thought that the repository is no longer maintained Le dim. 20 oct. 2024 à 18:26, Lars Müller ***@***.***> a écrit :

…

it looks like you don't want my participation thank you ciao I'm not sure how you arrived at this conclusion. I reviewed your participation because I wouldn't want it to merge as-is yet. — Reply to this email directly, view it on GitHub <#1733 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZGAU5JH32VLUFJWX75COFTZ4PYU3AVCNFSM6AAAAABQBXRF6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRVGE3DSMBTG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[appgurueu]

so give me the changes I need to make

I already explained what you need to change. Is there anything you don't understand about my review comments?

I made 3 pull requests and since then I haven't seen a response

As far as I'm concerned, I only see you having made a single pull request in a repository I maintain: This one.
Also, obligatory please be patient.