Fixes #1666: Remove duplicate entry of Sieve of Eratosthenes#1712
Open
ApeSkillx wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Fixes #1666: Remove duplicate entry of Sieve of Eratosthenes#1712ApeSkillx wants to merge 2 commits intoTheAlgorithms:masterfrom
ApeSkillx wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
appgurueu
requested changes
Oct 6, 2024
Collaborator
appgurueu
left a comment
There was a problem hiding this comment.
Please get rid of the unrelated changes to MobiusFunction.js, package-lock.json and package.json. Otherwise this looks fine.
…and package.json to address review feedback
Author
@appgurueu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1666
SieveOfEratosthenes.jsfile, which contained the boolean array implementation.SieveOfEratosthenesIntArray.jstoSieveOfEratosthenes.jsto maintain a cleaner and clearer implementation.All tests pass locally.
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.