Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier fixes & added test cases for Project Euler problem 4 #1566

Merged
merged 13 commits into from
Oct 24, 2023

Conversation

pomkarnath98
Copy link
Member

@pomkarnath98 pomkarnath98 commented Oct 22, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pomkarnath98 pomkarnath98 added hacktoberfest Created during hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 23, 2023
@pomkarnath98
Copy link
Member Author

Added hacktoberfest-accepted labels because only test cases were added, which are verified.

@appgurueu
Copy link
Collaborator

Added hacktoberfest-accepted labels because only test cases were added, which are verified.

FYI, I don't think it's necessary to add these labels:

Your PR/MRs must be in a repo tagged with the “hacktoberfest” topic, or have the “hacktoberfest-accepted” label.

and

Your PR/MRs must be merged, have the “hacktoberfest-accepted” label, or have an overall approving review.

@pomkarnath98 pomkarnath98 mentioned this pull request Oct 24, 2023
11 tasks
@appgurueu appgurueu merged commit 9a87526 into TheAlgorithms:master Oct 24, 2023
2 checks passed
@pomkarnath98 pomkarnath98 mentioned this pull request Oct 25, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Created during hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants