Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sleep Sort #109

Merged
merged 1 commit into from
May 23, 2021
Merged

Conversation

saurabhbazzad
Copy link
Contributor

Added the algorithm for Sleep Sort.

@cclauss
Copy link
Member

cclauss commented May 14, 2020

This looks cool to me. Would you be willing to help us with #142 (comment) by adding some doctests like https://github.com/TheAlgorithms/Javascript/blob/master/Sorts/BogoSort.js#L6-L13 and then turn them on at https://github.com/TheAlgorithms/Javascript/blob/master/.github/workflows/nodejs.yml#L18 ?

We are trying to understand how difficult it is for new contributors to add doctests so your work on this and feedback would be much appreciated.

@cclauss cclauss requested a review from itsvinayak May 14, 2020 05:36
Copy link
Member

@itsvinayak itsvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it out

@stale
Copy link

stale bot commented Feb 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Will not be fixed or is a feature label Feb 18, 2021
@cclauss cclauss closed this Feb 18, 2021
@raklaptudirm raklaptudirm reopened this May 23, 2021
@stale stale bot removed the wontfix Will not be fixed or is a feature label May 23, 2021
@raklaptudirm raklaptudirm merged commit 8b7b485 into TheAlgorithms:master May 23, 2021
@cclauss
Copy link
Member

cclauss commented May 23, 2021

  1. How much does this slow down our CI test runs?
  2. Does it properly sort floating point numbers and negative numbers?

@cclauss
Copy link
Member

cclauss commented May 23, 2021

TheAlgorithms/Python#2352

@raklaptudirm
Copy link
Member

raklaptudirm commented May 23, 2021

@cclauss Fixed. See #611 . I merged it because it was approved btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants