Skip to content

refactor: adding docs for LongestCommonPrefixTest and Parameterized Tests #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 9, 2025

  • Refactored LongestCommonPrefixTest to use JUnit 5 @ParameterizedTest with @MethodSource for cleaner and more maintainable test cases.

  • Improved readability by including input/output context in test names.

  • Preserved all original test logic while consolidating and simplifying the structure.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.64%. Comparing base (3e0fd11) to head (e20a4ea).

Files with missing lines Patch % Lines
...com/thealgorithms/strings/LongestCommonPrefix.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6360      +/-   ##
============================================
- Coverage     74.65%   74.64%   -0.02%     
+ Complexity     5451     5450       -1     
============================================
  Files           682      682              
  Lines         19015    19014       -1     
  Branches       3673     3673              
============================================
- Hits          14196    14193       -3     
- Misses         4261     4262       +1     
- Partials        558      559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far @alxkm ! Keep up the great work, really helpful :)

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) July 11, 2025 19:39
@DenizAltunkapan DenizAltunkapan merged commit 048bba9 into TheAlgorithms:master Jul 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants