Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Enhance docs, add tests in MaxHeap #5983

Merged
merged 17 commits into from
Oct 29, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 24, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.71%. Comparing base (d1c1e6b) to head (eb6981a).

Files with missing lines Patch % Lines
...om/thealgorithms/datastructures/heaps/MaxHeap.java 82.60% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5983      +/-   ##
============================================
+ Coverage     72.39%   72.71%   +0.31%     
- Complexity     4988     5025      +37     
============================================
  Files           654      654              
  Lines         17586    17603      +17     
  Branches       3388     3392       +4     
============================================
+ Hits          12732    12800      +68     
+ Misses         4372     4316      -56     
- Partials        482      487       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 24, 2024 07:05
@Hardvan Hardvan requested a review from siriak October 29, 2024 04:25
siriak
siriak previously approved these changes Oct 29, 2024
@siriak siriak enabled auto-merge (squash) October 29, 2024 17:50
@siriak siriak disabled auto-merge October 29, 2024 20:47
@siriak siriak merged commit 03bb8ee into TheAlgorithms:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants