Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SlidingWindowMaximum new algorithm with Junit tests #5839

Merged
merged 8 commits into from
Oct 26, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 15, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.55%. Comparing base (f20f8d1) to head (0dc55cf).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5839      +/-   ##
============================================
+ Coverage     70.52%   70.55%   +0.02%     
- Complexity     4820     4828       +8     
============================================
  Files           644      645       +1     
  Lines         17458    17472      +14     
  Branches       3359     3364       +5     
============================================
+ Hits          12313    12327      +14     
  Misses         4681     4681              
  Partials        464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 15, 2024 07:17
siriak
siriak previously approved these changes Oct 26, 2024
@siriak siriak enabled auto-merge (squash) October 26, 2024 07:56
auto-merge was automatically disabled October 26, 2024 08:41

Head branch was pushed to by a user without write access

@Hardvan Hardvan requested a review from siriak October 26, 2024 08:42
siriak
siriak previously approved these changes Oct 26, 2024
@Hardvan Hardvan requested a review from siriak October 26, 2024 09:37
@siriak siriak enabled auto-merge (squash) October 26, 2024 11:41
@siriak siriak merged commit 04e421b into TheAlgorithms:master Oct 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants