Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for RomanToInteger #3686

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Add test case for RomanToInteger #3686

merged 2 commits into from
Oct 27, 2022

Conversation

naanagon
Copy link
Contributor

@naanagon naanagon commented Oct 26, 2022 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@naanagon
Copy link
Contributor Author

@siriak , @yanglbme Test cases passed. Can you please take a look..?

@naanagon
Copy link
Contributor Author

@siriak , @yanglbme - could you please review, build is green now.

@naanagon naanagon changed the title Added test cases for roman-to-integer Add test case for roman to integer Oct 27, 2022
@naanagon naanagon changed the title Add test case for roman to integer Add test case for RomanToInteger Oct 27, 2022
@yanglbme yanglbme merged commit 8504e6a into TheAlgorithms:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naanagon @yanglbme