Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ReverseStringTest for both implementations of reverse #3607

Merged
merged 3 commits into from
Oct 22, 2022
Merged

Adding ReverseStringTest for both implementations of reverse #3607

merged 3 commits into from
Oct 22, 2022

Conversation

Tuong328
Copy link
Contributor

@Tuong328 Tuong328 commented Oct 20, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.

jpsxlr8
jpsxlr8 reviewed Oct 22, 2022
View reviewed changes
Copy link

@jpsxlr8 jpsxlr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can utilize the built-in StringBuilder and StringBuffer class to enhance the efficiency of the code.

siriak
siriak approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 22, 2022 19:21
@siriak siriak disabled auto-merge October 22, 2022 19:21
@siriak siriak enabled auto-merge (squash) October 22, 2022 19:21
@siriak siriak merged commit f35aeb5 into TheAlgorithms:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsxlr8 jpsxlr8 jpsxlr8 left review comments

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tuong328 @siriak @jpsxlr8