Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: max func without using conditional operators #347

Merged
merged 2 commits into from
Sep 17, 2021
Merged

feat: max func without using conditional operators #347

merged 2 commits into from
Sep 17, 2021

Conversation

i-redbyte
Copy link
Member

add an algorithm for finding the maximum number without using conditional operators

raklaptudirm
raklaptudirm requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest renaming it to bitwiseMax.

@i-redbyte
Copy link
Member Author

I would suggest renaming it to bitwiseMax.

fixed it

@i-redbyte
Copy link
Member Author

and who is merging the pull request?

siriak
siriak approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'm merging it :)

@siriak siriak merged commit bcb29db into TheAlgorithms:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@siriak siriak siriak approved these changes

@tjgurwara99 tjgurwara99 Awaiting requested review from tjgurwara99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-redbyte @siriak @raklaptudirm