Refresh Pancake Sort #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 17.8% 19.98% +2.18%
==========================================
Files 32 32
Lines 1685 1671 -14
Branches 262 261 -1
==========================================
+ Hits 300 334 +34
+ Misses 1378 1330 -48
Partials 7 7
Continue to review full report at Codecov.
|
|
I will modify the PancakeSorter.cs file in line with codacy-bot's recommendation: Codacy Issue found: Do not update the loop counter 'mi' within the loop body. |
siriak
reviewed
Jun 15, 2019
|
Reopened Pull Request |
Co-Authored-By: Andrii Siriak <siryaka@gmail.com>
Co-Authored-By: Andrii Siriak <siryaka@gmail.com>
siriak
approved these changes
Jun 15, 2019
Adelhaide22
pushed a commit
to Adelhaide22/C-Sharp
that referenced
this pull request
Jul 5, 2019
* Refresh Pancake Sort * Update Algorithms/Sorters/PancakeSorter.cs Co-Authored-By: Andrii Siriak <siryaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshed the "Pancake Sorter" Implementation in line with other "sorter" refreshes.
One File Deletion
--> pancake_sort.cs
Two File Additions
--> Algorithms.Tests/Sorters/PancakeSorterTests.cs
--> Algorithms/Sorters/PancakeSorter.cs
Tested with Random Integer Array
Built successfully in Debug and Release