Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Z Algorithm #314

Closed
wants to merge 1 commit into from
Closed

Conversation

Jenn-1212
Copy link

  • [x ] I have performed a self-review of my code
  • [x ] My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • x[ ] I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@Jenn-1212 Jenn-1212 requested a review from siriak as a code owner August 9, 2022 04:49
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #314 (b215f2a) into master (1ffea49) will decrease coverage by 1.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   95.16%   94.14%   -1.03%     
==========================================
  Files         182       50     -132     
  Lines        7965     3722    -4243     
==========================================
- Hits         7580     3504    -4076     
+ Misses        385      218     -167     
Impacted Files Coverage Δ
Utilities/Extensions/RandomExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
Utilities/Extensions/DictionaryExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
Utilities/Extensions/VectorExtensions.cs 0.00% <0.00%> (-94.37%) ⬇️
Utilities/Extensions/MatrixExtensions.cs 87.12% <0.00%> (-12.88%) ⬇️
DataStructures/DisjointSet/DisjointSet.cs 81.48% <0.00%> (-11.12%) ⬇️
DataStructures/Graph/DirectedWeightedGraph.cs 93.10% <0.00%> (-6.90%) ⬇️
...ithms/Sorters/Comparison/MiddlePointQuickSorter.cs
Algorithms/Sorters/Comparison/TimSorter.cs
Algorithms/Numeric/Series/Maclaurin.cs
...ms/Sequences/NumberOfPrimesByPowersOf10Sequence.cs
... and 128 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add tests, remove entry point, and fix other PR checks

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 11, 2022
@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants