Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binomial, Factorial sequences added, existing updated with length parameter, minor refactors in AATreeTest, readme updated #199

Merged
merged 22 commits into from
Jan 23, 2021

Conversation

kolosovpetro
Copy link
Contributor

@kolosovpetro kolosovpetro commented Jan 21, 2021

Please include a summary of the change. Please also include relevant motivation and context (if applicable).

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added comments to hard-to-understand areas of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the comments
  • I have made corresponding changes to the README.md

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #199 (0fb8cf0) into master (2c63986) will increase coverage by 0.01%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   92.52%   92.54%   +0.01%     
==========================================
  Files          95       97       +2     
  Lines        4348     4385      +37     
==========================================
+ Hits         4023     4058      +35     
- Misses        325      327       +2     
Impacted Files Coverage Δ
Algorithms/Sequences/BinomialSequence.cs 92.85% <92.85%> (ø)
Algorithms/Sequences/FactorialSequence.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c63986...0fb8cf0. Read the comment docs.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you make sequences infinite as they were before? Those sequences are infinite by their nature and we can take with .Take(n) or skip with .Skip(n) as many elements as we want.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@siriak siriak merged commit 2f24696 into TheAlgorithms:master Jan 23, 2021
XtianKav added a commit to XtianKav/C-Sharp that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants