Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private keyword #196

Closed
wants to merge 3 commits into from
Closed

Remove private keyword #196

wants to merge 3 commits into from

Conversation

simon-parry
Copy link

Removed private keyword

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #196 (a9bbfb1) into master (5a6f50e) will decrease coverage by 2.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   92.41%   90.00%   -2.41%     
==========================================
  Files          94       74      -20     
  Lines        4297     2431    -1866     
==========================================
- Hits         3971     2188    -1783     
+ Misses        326      243      -83     
Impacted Files Coverage Δ
...tructures/BinarySearchTree/BinarySearchTreeNode.cs
DataStructures/BitArray.cs
DataStructures/BinaryHeap.cs
DataStructures/MinMaxHeap.cs
...tructures/DoublyLinkedList/DoublyLinkedListNode.cs
DataStructures/Timeline.cs
DataStructures/SegmentTrees/SegmentTreeApply.cs
DataStructures/SegmentTrees/SegmentTreeUpdate.cs
DataStructures/AATree/AATree.cs
DataStructures/AATree/AATreeNode.cs
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6f50e...a9bbfb1. Read the comment docs.

@siriak
Copy link
Member

siriak commented Nov 20, 2020

This is a violation of the SA1400 rule. From build logs:
SinglyLinkedList/SinglyLinkedList.cs(13,34): error SA1400: Element 'Head' should declare an access modifier

@siriak siriak closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants