Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add approximate_pi.cpp file #1860

Merged
merged 16 commits into from
Jan 19, 2022
Merged

Add approximate_pi.cpp file #1860

merged 16 commits into from
Jan 19, 2022

Conversation

Qannaf
Copy link
Contributor

@Qannaf Qannaf commented Dec 31, 2021 •
edited
Loading

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Qannaf
Copy link
Contributor Author

Qannaf commented Dec 31, 2021

This function approximate pi using the given points

Qannaf
Qannaf commented Jan 1, 2022
View reviewed changes
Copy link
Contributor Author

@Qannaf Qannaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jan 2, 2022
Panquesito7
Panquesito7 requested changes Jan 2, 2022
View reviewed changes
math/approximate_pi.cpp Outdated Show resolved Hide resolved
math/approximate_pi.cpp Outdated Show resolved Hide resolved
math/approximate_pi.cpp Outdated Show resolved Hide resolved
math/approximate_pi.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the requested changes changes have been requested label Jan 2, 2022
Qannaf
Qannaf commented Jan 2, 2022
View reviewed changes
math/approximate_pi.cpp Outdated Show resolved Hide resolved
Qannaf and others added 4 commits January 2, 2022 09:10
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
cdb5d90 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
63e12cf 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
eeb8c5f 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf
Update math/approximate_pi.cpp
7d9de80
Qannaf
Qannaf commented Jan 2, 2022
View reviewed changes
Copy link
Contributor Author

@Qannaf Qannaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit Review changes

@Qannaf Qannaf requested a review from Panquesito7 January 11, 2022 22:04
Panquesito7
Panquesito7 requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😃

math/approximate_pi.cpp Outdated Show resolved Hide resolved
math/approximate_pi.cpp Outdated Show resolved Hide resolved
math/approximate_pi.cpp Outdated Show resolved Hide resolved
math/approximate_pi.cpp Show resolved Hide resolved
math/approximate_pi.cpp Show resolved Hide resolved
Qannaf and others added 5 commits January 18, 2022 11:48
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
3a8fbe2 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
0f834a6 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
b202136 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf
Update approximate_pi.cpp
17689eb
@Qannaf @Panquesito7
Update math/approximate_pi.cpp
a41bbe0 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Qannaf Qannaf requested a review from Panquesito7 January 18, 2022 11:03
@Qannaf Qannaf requested a review from Panquesito7 January 19, 2022 13:36
Panquesito7
Panquesito7 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@Panquesito7 Panquesito7 merged commit 9a58357 into TheAlgorithms:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request requested changes changes have been requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qannaf @Panquesito7