feat(standards): apply TheOne Studio coding standards #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add #nullable enable to 73 files for null safety - Seal 35 classes to prevent unintended inheritance - Replace Debug.Log with ILogger for production logging - Add conditional compilation directives - Fix ILogger.Error() calls (separate Error/Exception) - Update .gitignore to track 113 .meta files - Include DifficultyConfig.cs.meta for GUID preservation 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
|
please remove all |
|
No inline comments, everything should have descriptive names, only add comments when necessary |
|
logger must not be null right from the constructor, no need checking for null, use nullable annotation only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply TheOne Studio coding standards and best practices across the DynamicUserDifficulty module.
Changes
#nullable enabledirective to 73 C# filessealedkeyword to 35 classes to prevent unintended inheritanceDebug.Logcalls withILoggerfor production-safe logging#if UNITY_EDITOR || DEVELOPMENT_BUILDguards for debug logsILogger.Error()calls to use separateError()andException()methodsFiles Changed
Testing
✅ Compilation verified - no breaking changes
⏳ Pending: Run 164 Unity tests manually via Test Runner
🤖 Generated with Claude Code