Add TPMA sub-type dropdown - #243
Conversation
|
Hi @swyatt-SU, I've added in a sub-type dropdown to the app and deployed it to the development version of the app. We're interested in your thoughts. To note:
Feel free to make some comments as well, @Lextuga007, though this is still a draft PR for now and there'll be a chance for proper review when ready. |
|
I noticed a spelling mistake in the description but that's not related to this PR code but just to note I've raised an issue from where the text originates (currently in two repositories and https://github.com/The-Strategy-Unit/nhp_planning/issues/734 to this to be reconsidered). |
|
Thanks @matt-dray . All looks good to me. When the app opens should it default to the overview tab? For me it's starting on the explore data tab. |
|
Thanks @Lextuga007. This repo currently reads the descriptions directly from the nhp_inputs repository on GiHub, but we should prefer the centralised TPMAs repo once they're there. And thanks @swyatt-SU. The current production version of the app goes straight to the data exploration page as well, so this dev version is just copying that behaviour. I think the idea was that the majority of users just want to start digging in. Happy to review that though. I also noticed that the default TPMA in this dev version is not the same one as the production app—Ambulatory Care Sensitive Admissions (Acute Conditions)—so I'll make sure that's set correctly as well. (Edit: this has been updated in the latest commit and redeployed to dev.) |
|
Tests passing now, so taking it out of draft. After merge it can be released as v0.8.0 and deployed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1234 1294 +60
=========================================
+ Hits 1234 1294 +60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Close #226.