Skip to content

Add TPMA sub-type dropdown - #243

Open
matt-dray wants to merge 11 commits into
mainfrom
226-subtype
Open

Add TPMA sub-type dropdown#243
matt-dray wants to merge 11 commits into
mainfrom
226-subtype

Conversation

@matt-dray

@matt-dray matt-dray commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Close #226.

  • Separated TPMA dropdown into two: split 'code: name (sub-type)' into 'name' and 'sub-type'.
  • Protected against transient states where the name and sub-type could get desynchronised.
  • Enabled bookmark restoration of sub-type state.
  • Added full TPMA name including TPMA code into the description card.
  • Update tests.

@matt-dray matt-dray self-assigned this Aug 12, 2026
@matt-dray matt-dray added enhancement New feature or request priority: must MoSCoW priority labels Aug 12, 2026
@matt-dray

matt-dray commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Hi @swyatt-SU, I've added in a sub-type dropdown to the app and deployed it to the development version of the app. We're interested in your thoughts.

To note:

  • the sub-type box dropdown is disabled and says 'No TPMA sub-types to show' if that's the case
  • I've rendered the 'full' TPMA name in the 'Description' box
  • the development version of the app also has the SU theme applied, so feel free to comment on that as well

Feel free to make some comments as well, @Lextuga007, though this is still a draft PR for now and there'll be a chance for proper review when ready.

@Lextuga007

Lextuga007 commented Aug 13, 2026

Copy link
Copy Markdown
Member

I noticed a spelling mistake in the description but that's not related to this PR code but just to note I've raised an issue from where the text originates (currently in two repositories and https://github.com/The-Strategy-Unit/nhp_planning/issues/734 to this to be reconsidered).

@swyatt-SU

Copy link
Copy Markdown
Member

Thanks @matt-dray . All looks good to me.

When the app opens should it default to the overview tab? For me it's starting on the explore data tab.

@matt-dray

matt-dray commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @Lextuga007. This repo currently reads the descriptions directly from the nhp_inputs repository on GiHub, but we should prefer the centralised TPMAs repo once they're there.

And thanks @swyatt-SU. The current production version of the app goes straight to the data exploration page as well, so this dev version is just copying that behaviour. I think the idea was that the majority of users just want to start digging in. Happy to review that though.

I also noticed that the default TPMA in this dev version is not the same one as the production app—Ambulatory Care Sensitive Admissions (Acute Conditions)—so I'll make sure that's set correctly as well. (Edit: this has been updated in the latest commit and redeployed to dev.)

@matt-dray

Copy link
Copy Markdown
Contributor Author

Tests passing now, so taking it out of draft. After merge it can be released as v0.8.0 and deployed.

@matt-dray
matt-dray marked this pull request as ready for review August 19, 2026 17:24
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0af6eb1) to head (6aee017).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1234      1294   +60     
=========================================
+ Hits          1234      1294   +60     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: must MoSCoW priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TPMA sub-type selector in the sidebar

3 participants