deprecate results json creation

[tomjemmett]

resolves Fix TODO: Fully deprecate JSON results format
Fixes #286

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4edc7cb) to head (228959c).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #657   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1162      1130   -32     
  Branches        64        61    -3     
=========================================
- Hits          1162      1130   -32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

✅ A new build is available.

You can use the following to use pull the image into your local environment:

docker pull ghcr.io/the-strategy-unit/nhp_model:pr-657

[Copilot]

Pull request overview

This PR completes the deprecation of the legacy “results JSON” output by removing JSON result generation in the model layer and the corresponding upload path in the Docker/Azure runner, along with associated unit tests.

Changes:

• Removed generate_results_json implementation from nhp.model.results.
• Removed results JSON upload logic from nhp.docker.run.RunWithAzureStorage.
• Deleted unit tests covering the deprecated JSON output path.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/unit/nhp/model/test_results.py	Removes unit test coverage for deprecated results JSON generation.
tests/unit/nhp/docker/test_run.py	Removes unit tests for deprecated results JSON upload and related finish-path assertions.
src/nhp/model/results.py	Deletes the deprecated generate_results_json implementation, leaving parquet/params/variants outputs.
src/nhp/docker/run.py	Removes the results JSON upload path and corresponding import usage.

Suppressed comments (1)

src/nhp/docker/run.py:289

• The standalone ## --- marker no longer separates any conditional/deprecation block (the JSON upload code was removed). Leaving it in place is confusing and should be removed.

        ## ---
        if save_full_model_results:
            self._upload_full_model_results()

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.