Update extract - #263
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Databricks extraction/upload script to authenticate to Azure Storage via an app registration (client secret credential) instead of SAS tokens, and adds extraction of the “synth” dataset alongside existing dev datasets.
Changes:
- Replaces SAS-token-based storage access with
ClientSecretCredentialbuilt from Databricks secrets. - Updates the internal move/upload helper to accept an AAD credential and wires it through callers.
- Adds a new
move_synth_data(...)path to uploadmodel_data/synthunder thesynth/prefix.
Comments suppressed due to low confidence (1)
src/nhp/data/extract_data.py:96
- This error message still references SAS token setup, but the script now uses an app registration (client secret) credential. Update the message (and ideally the module docstring/instructions) so operators know what to configure.
print(
"Error moving files, have you followed the instructions for generating the SAS token?"
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yiwen-h
approved these changes
Jun 17, 2026
yiwen-h
left a comment
Member
There was a problem hiding this comment.
Talked through on a call. Better than using SAS tokens, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch to using app registration with client secret credentials over sas tokens. also extracts the synth data