Skip to content

Update extract - #263

Merged
tomjemmett merged 6 commits into
mainfrom
update_extract
Jun 17, 2026
Merged

Update extract#263
tomjemmett merged 6 commits into
mainfrom
update_extract

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

switch to using app registration with client secret credentials over sas tokens. also extracts the synth data

@tomjemmett
tomjemmett requested a review from a team as a code owner June 17, 2026 12:12
Copilot AI review requested due to automatic review settings June 17, 2026 12:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Databricks extraction/upload script to authenticate to Azure Storage via an app registration (client secret credential) instead of SAS tokens, and adds extraction of the “synth” dataset alongside existing dev datasets.

Changes:

  • Replaces SAS-token-based storage access with ClientSecretCredential built from Databricks secrets.
  • Updates the internal move/upload helper to accept an AAD credential and wires it through callers.
  • Adds a new move_synth_data(...) path to upload model_data/synth under the synth/ prefix.
Comments suppressed due to low confidence (1)

src/nhp/data/extract_data.py:96

  • This error message still references SAS token setup, but the script now uses an app registration (client secret) credential. Update the message (and ideally the module docstring/instructions) so operators know what to configure.
        print(
            "Error moving files, have you followed the instructions for generating the SAS token?"
        )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/nhp/data/extract_data.py Outdated

@yiwen-h yiwen-h left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked through on a call. Better than using SAS tokens, thank you

@tomjemmett
tomjemmett merged commit 03bff6f into main Jun 17, 2026
3 checks passed
@tomjemmett
tomjemmett deleted the update_extract branch June 17, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants