removes custom population projections - #252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the bespoke/custom population projection paths from the model-data extraction pipeline, leaving provider projections to be generated solely from the standard population projections tables.
Changes:
- Removed the custom demographic factors generation for RD8 and R0A66 and stopped unioning custom variants into the extracted demographic factors output.
- Refactored
extract_custom_birth_factorsto accept multiple custom projections, and updatedextract()to currently pass an empty list (disabling custom birth factor generation).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/nhp/data/model_data/demographic_factors.py |
Deletes custom demographic factor builders and stops appending custom projection variants to the extracted output. |
src/nhp/data/model_data/birth_factors.py |
Generalizes custom birth factor extraction to a list-driven API and disables custom projection generation by passing an empty list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
yiwen-h
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.