refactor virtual wards - #106
Merged
Merged
Conversation
tomjemmett
commented
May 16, 2025
tomjemmett
commented
Member
- refactor virtual wards
- refactors inpatient mitigators script
previously we defined all of the logic in activity avoidance, then imported activity avoidance into efficiencies. however, that could cause an error as the activity avoidance mitigators would try to be defined twice when run with the reflective import (in raw_data.inpatients_mitigators.py). moved the logic into a new 'shared' folder where we can re-use logic as needed
previously used some logic for reporting errors but continuing anyway. this was useful when initially building, but it can mask errors. this forces errors to be shown and stop excecution (so, tasks will fail)
yiwen-h
requested changes
May 16, 2025
yiwen-h
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.