Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: remove jiayouba233's third_party binary resource dependency #146

Merged
merged 1 commit into from
Apr 17, 2022
Merged

bugfix: remove jiayouba233's third_party binary resource dependency #146

merged 1 commit into from
Apr 17, 2022

Conversation

Certseeds
Copy link
Contributor

  • Bug fix
  • Documentation update
  1. do not use absolute path,use relative path
  2. use third_party repo's binary resource is dangerous

@netlify
Copy link

netlify bot commented Apr 17, 2022 •
edited
Loading

❌ Deploy Preview for storied-kataifi-e890e1 failed.

Name Link
🔨 Latest commit f5b5a6b
🔍 Latest deploy log https://app.netlify.com/sites/storied-kataifi-e890e1/deploys/625be3467e753a0008d0073a

@Certseeds
Copy link
Contributor Author

fix #145

the-run-philosophy
the-run-philosophy requested changes Apr 17, 2022
View reviewed changes
@Certseeds
bugfix: remove jiayouba233's third_party binary resource dependency
f5b5a6b 
</subject>

Branch: master

<type>:
- [x] Bug fix
- [ ] Bug fix (Test)
- [ ] New feature
- [ ] Breaking change
- [x] Documentation update
- [ ] This change requires a documentation update

<body>

1. do not use absolute path,use relative path
2. use third_party repo's binary resource is dangerous

<footer>

Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
the-run-philosophy
the-run-philosophy approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member

@the-run-philosophy the-run-philosophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@the-run-philosophy the-run-philosophy merged commit 082ab7e into The-Run-Philosophy-Organization:main Apr 17, 2022
@ghost ghost mentioned this pull request Apr 23, 2022
Merged
@ghost ghost mentioned this pull request May 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-run-philosophy the-run-philosophy the-run-philosophy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Certseeds @the-run-philosophy