Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix guide above TOP_ROUTING_LAYER #1405

Conversation

openroad-robot
Copy link
Contributor

Signed-off-by: stephano stephanommg@yahoo.com.br

Signed-off-by: stephano <stephanommg@yahoo.com.br>
@Stephanommg Stephanommg requested a review from maliberty December 8, 2021 19:34
@Stephanommg Stephanommg marked this pull request as ready for review December 8, 2021 19:34
@maliberty
Copy link
Member

I'll approve once you cleanup the CI issues.

@Stephanommg
Copy link
Contributor

I'll approve once you cleanup the CI issues.

I really dont understand what is going on. The errors are that some metrics are missing, and ispd sample regression fails, but the metrics are there (in the remote branch), and the regression passes in my machine.

@maliberty
Copy link
Member

Your OR version in this branch is behind the head of secure-TR_GuideFix.

I ran with the head of secure-TR_GuideFix and on ispd18_sample.tcl I get:

[INFO DRT-0033] Metal8 shape region query size = 0.
[INFO DRT-0033] Via8 shape region query size = 0.
[INFO DRT-0033] Metal9 shape region query size = 0.
Error: out of memory.

@maliberty
Copy link
Member

maliberty commented Dec 8, 2021

I think you are failing on:

int TOP_ROUTING_LAYER = std::numeric_limits::max();

in which case:
vector<map<frCoord, boost::icl::interval_set>> intvs(
min((int)tech->getLayers().size(), TOP_ROUTING_LAYER+1));

is huge and negative

@Stephanommg
Copy link
Contributor

secure-TR_GuideFix

This branch is secure-TR_GuideFix, how can it be behind it? You meant it is behind master?

@maliberty
Copy link
Member

This branch is secure-TR_GuideFix, how can it be behind it? You meant it is behind master?

I mean the ORFS points to an older OR version. I guess it doesn't matter for these tests, just secure CI.

@Stephanommg
Copy link
Contributor

I think you are failing on:

int TOP_ROUTING_LAYER = std::numeric_limits::max();

in which case: vector<map<frCoord, boost::icl::interval_set>> intvs( min((int)tech->getLayers().size(), TOP_ROUTING_LAYER+1));

is huge and negative

Ok, going to correct it.

Signed-off-by: stephano <stephanommg@yahoo.com.br>
@Stephanommg
Copy link
Contributor

This branch is secure-TR_GuideFix, how can it be behind it? You meant it is behind master?

I mean the ORFS points to an older OR version. I guess it doesn't matter for these tests, just secure CI.

Started a new secure-CI with the bugfix

@Stephanommg Stephanommg requested a review from maliberty December 9, 2021 12:55
@Stephanommg Stephanommg merged commit cb28034 into The-OpenROAD-Project:master Dec 9, 2021
@openroad-robot openroad-robot deleted the secure-TR_GuideFix branch December 9, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants