Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: fix segfault on heatmap and power density #1372

Merged
merged 2 commits into from
Dec 1, 2021
Merged

gui: fix segfault on heatmap and power density #1372

merged 2 commits into from
Dec 1, 2021

Conversation

openroad-robot
Copy link
Contributor

Fixes:

  • previously the power was not getting scaled correctly causing macros to have huge power values, this ensures that the power is scaled for the area of the macro
  • Segfault on large maps when modifying settings in the setup window causing the RTree to be cleared without ensure its not getting accessed.

@gadfort
gui: correct modify combineMapData and correct power density assignments
37c7254 
Signed-off-by: Peter Gadfort <peter.gadfort.civ@army.mil>
@gadfort
gui: dont clear map, but use flag to indicate map clearing on next en…
f7758df 
…sureMap to prevent RTree access after clear

Signed-off-by: Peter Gadfort <peter.gadfort.civ@army.mil>
@gadfort gadfort marked this pull request as ready for review December 1, 2021 15:32
@gadfort gadfort requested a review from maliberty December 1, 2021 15:33
@gadfort gadfort merged commit c8e51bd into The-OpenROAD-Project:master Dec 1, 2021
@openroad-robot openroad-robot deleted the gui-fix-heat-map branch December 1, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openroad-robot @maliberty @gadfort