Make tcl compilation work with ancient Tcl versions.#10061
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 6, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a Tcl_Size typedef across multiple SWIG interface files to support Tcl 9. Review feedback indicates that the current preprocessor guard is too broad and will cause compilation errors on Tcl 8.6.13 and later, where Tcl_Size is already defined as a macro. The reviewer recommends adding !defined(Tcl_Size) to the guards and suggests centralizing this logic to reduce duplication across the codebase.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
In Tcl versions before 8.6.13, the type Tcl_Size was not available. Add typedefs for these to be able to compile with these ancient versions. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260406-fallback-tclsize
branch
from
a1f7f96 to
c52de13
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
ci faliures look like they are due to random download issues. |
Collaborator
Author
|
@mikesinouye FYI |
Member
|
Looking forward to bzl and not dealing with local tcl versions. |
maliberty
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Tcl versions before 8.6.13, the type Tcl_Size
was not available. Add typedefs for these to be able to compile with these ancient versions of Tcl.