flow: faster, leaner single openroad invocation flows #3740
Conversation
oharboe
force-pushed
the
single-openroad-invocation-flows
branch
from
2f656fd to
08f742e
Compare
This commit is only to simplify the review. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
no longer save out all .odb/.sdc files automatically, the user can save out as many or as few as they need. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
force-pushed
the
single-openroad-invocation-flows
branch
from
08f742e to
b7a8ba7
Compare
I don't see a change in the default flow. I suppose you mean it in the context of the SINGLE_OPENROAD_INVOCATION_FLOW. SINGLE_OPENROAD_INVOCATION_FLOW doesn't actually control the invocation of OR so it feels odd. Further you might want a single invocation flow to write out an .odb at each step even if it doesn't exit, so this feels orthogonal. |
erasing variables or not and saving sdc/odb after each stage are now different variables Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Fixed. |
flow/scripts/floorplan_to_place.tcl
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Enable keeping variables between stages | |||
| set ::env(KEEP_VARS) 1 | |||
| set ::env(WRITE_ODB_AND_SDC_EACH_STAGE) 0 | |||
There was a problem hiding this comment.
This will prevent the user from overriding it. I think this should only be set if currently unset.
There was a problem hiding this comment.
Consistent with other variables, I have added default values in variables.yaml as a perference, so if I check if these values are set, they always are. Hence, I set them to explicitly here, which I think is the intent of the script.
Do you have any more information about the use-case of this script, I'm guessing here.
There was a problem hiding this comment.
The intent of the script is to perform all operations in a single invocation. Whether to write odb at each stage or not is a separate decision. @eder-matheus does this matter for you?
There was a problem hiding this comment.
In the scenario I'm using it, I'm interested on the ODB files of each stage. However, I'm not against having it as an option, and the default behavior would be not writing the ODBs of each stage.
This PR now adds the option of skipping saving of .odb/.sdc files only Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
@eder-matheus @maliberty Should be all good now. Anything else? |
3 participants
no longer save out all .odb/.sdc files automatically, the user can save out as many or as few as they need.