Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Placement #1684

Merged
merged 11 commits into from
Mar 22, 2023
Merged

Rework Placement #1684

merged 11 commits into from
Mar 22, 2023

Conversation

donn
Copy link
Collaborator

@donn donn commented Mar 16, 2023

  • Add warning when attempting to run Sylvain's script without DPL_CELL_PADDING >= 0
  • Add warning when DPL_CELL_PADDING is set to greater than GPL_CELL_PADDING
    ~ Use $HOME/.volare as the default PDK location
    ~ PL_TARGET_DENSITY incorporates value of GPL_CELL_PADDING in calculation
    ~ Updated various config files to handle new default padding options
    ~ CI bugfixes + support for Volare 0.7.1

[ci ets]


Depends on RTimothyEdwards/open_pdks#358.

donn and others added 4 commits March 16, 2023 14:00
+ Add warning when attempting to run Sylvain's script without `DPL_CELL_PADDING` >= 0
+ Add warning when DPL_CELL_PADDING is set to greater than GPL_CELL_PADDING
~ `PL_TARGET_DENSITY` incorporates value of `GPL_CELL_PADDING` in calculation
~ Updated various config files to have an explicit padding of 2
@donn donn marked this pull request as ready for review March 21, 2023 12:19
@donn donn requested a review from kareefardi March 21, 2023 15:05
@donn donn requested a review from marwaneltoukhy March 22, 2023 10:17
@marwaneltoukhy
Copy link
Collaborator

Why not change the default of DPL_CELL_PADDING so by default the diode insertion strategies work fine?

@donn
Copy link
Collaborator Author

donn commented Mar 22, 2023

@marwaneltoukhy It triples the design area and is only needed for the custom script, which is disabled by default in favor of DIS 3.

@donn donn merged commit e5a7a09 into The-OpenROAD-Project:master Mar 22, 2023
@donn donn deleted the rework_placement branch March 22, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants