-
Notifications
You must be signed in to change notification settings - Fork 15
Integration of MongoDB for feedbacks - Revised #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@luarss , even now I believe there is some problem with the CI pipeline, what should we do for the same? |
Do you mean to reference them as context IDs? Where would we see the mapping between context ID and their contents? |
so my idea is ,I have a main table for all the information and then a table for context, within that table I am abstracting all the details related to context, so you can reference the context details using the context ID assigned to it, my assumption was there are a limited number of context right now, so it shouldn't be a problem , but I just wanted to clarify this with you |
3311e31 to
c4161ef
Compare
|
Hello, sorry for the delayed response. Can you please send me your e-mail at jluar@precisioninno.com so we can further discuss about this offline? |
|
Sure, i'll send an email about this Thank you! |
|
Hey @luarss , so i was looking at different options for hosting MongoDB on GCP, I found two ways
Which one would you prefer? |
|
Second one is preferred. Can you let me know what are the minimum requirements? |
|
So for the instance for containers deployment we can use GKE , and the instance type should be really small for now as we're just getting started with it so maybe any of the
On another note, I told you about the custom deployment options, but I forgot to tell you about that MongoDB atlas has a direct deployment feature from the cloud with google cloud, it is good but we might need to have a separate discussion if we're looking into this as well, This is the link for you reference: https://www.mongodb.com/resources/products/platform/mongodb-on-google-cloud Thank you |
|
Thanks for doing the research! I am more inclined towards the first solution of GKE. That is also what I chose for the prototype deployment of the RAG webapp. Let us go with the |
|
Got it, just to be on the same page, should I open up a separate issue related to the deployment of the Database, as this is kind of related to the development part, Also I had a question, should we proceed with the deployments after we're done with the UI and the feedback functionality for MongoDB, or should it be done in parallel. Thank you Jack! |
|
Yup, that is fine. Let's put the deployment details to a latter PR. |
|
perfect then, I will finish up with MongoDB implementation in this week with documentation and then we can work on UI dashboard once again thank you jack for your help and letting me be a part of this project |
|
Hey @luarss , hope you're doing well! Just something I wanted to discuss with you, in the previous meeting we talked about the database structure and how we can link the context right to the main schemas, turns out when the response is returned from the backend, it is returned in the following format You can see that it isn't mentioned from what source the context is coming from, but lets say if we were to assume that from what source is a particular context coming from , we might have to make changes to how data is sent back to the frontend, so we can derive a relationship whats your opinion on this? |
c4161ef to
311993d
Compare
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
311993d to
b370dca
Compare
|
sure, we can work on this , I was wondering if we can possibly have another meeting for the same, I need to also show you what I've been thinking about the same Thank you |
|
Sent you an e-mail. For meeting requests, feel free to drop me an e-mail :) |
|
Thank you for the review @luarss , I made changes to the backend, specifically the files Please do let me know if I can help you out in any way possible? Also should I start working on the documentation for the same Thank you once again for your guidance :) |
Signed-off-by: Jack Luar <jluar@precisioninno.com>
…rontend Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Song Luar <espsluar@gmail.com> Signed-off-by: luarss <39641663+luarss@users.noreply.github.com>
28a59f0 to
a1d4668
Compare
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Song Luar <jluar@precisioninno.com>
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Kannav Sethi <90309433+Kannav02@users.noreply.github.com>
|
@luarss @error9098x , this should be good for review now, the merge conflict is resolved Thank you! |
|
Hi @Kannav02, while running the streamlit with our backend I encountered this screen. The streamlit logs say that the feedback was submitted successfully - but I think there might be some problems with error handling in By the way, I started the backend with |
Signed-off-by: Jack Luar <jluar@precisioninno.com>
|
Thats pretty strange, I'll take a look into this as well, thank you @luarss |
|
@luarss , I found the issue, apparently one of the function Thank you! |
Signed-off-by: Kannav02 <kannavsethi02@gmail.com>
Signed-off-by: Song Luar <jluar@precisioninno.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge after CI is fixed. Thanks!


This PR aims to fix a small part of the issue #75
The objective of this PR can be tracked via the following points
feedbacktableTo view/test these changes, follow the following steps
MONGO_DB_URIto which the feedback and the context would be fed back toThis is what I got when I ran this twice
Follow-up question, are there limited number of contexts that we have right now for this application, if yes , I might optimize the database insertions rather not to insert the pre-existing contexts, but to reference them and insert their ids into the main table
Thank you!