Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal(other): Pre-Alpha M2 #91

Draft
wants to merge 163 commits into
base: develop-pre-alpha
Choose a base branch
from

Conversation

dieselxxx
Copy link
Contributor

Ticket

Please provide a link to the ticket related to this change.
Example: fixes # (issue).

Description

Please include a summary of the change.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of change

  • Bug fix
  • General fix
  • Incident fix
  • New feature
  • New enhancement
  • Optimization
  • Performance
  • Code refactor
  • Security fix
  • Suggestion
  • Documentation
  • Code revert
  • Internal development

@dieselxxx dieselxxx added platform: FireHub Core Core platform label. priority: Normal Normal priority issues or pull requests. scope: Other Issues or pull requests for undefined scope. status: Draft This issue or pull request in draft mode. type: Development Internel development pull request that usually contain large updates. labels Sep 23, 2024
@dieselxxx dieselxxx changed the title Added extra space internal(other): Pre-Alpha M2 Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 19.75052% with 1158 lines in your changes missing coverage. Please review.

Project coverage is 57.06%. Comparing base (c13c711) to head (f34c369).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/support/enums/firehub.Language.php 0.00% 382 Missing ⚠️
src/kernel/http/firehub.Request.php 0.00% 144 Missing ⚠️
src/kernel/http/firehub.Response.php 0.00% 84 Missing ⚠️
src/kernel/firehub.Server.php 0.00% 60 Missing ⚠️
src/support/enums/http/firehub.StatusCode.php 0.00% 59 Missing ⚠️
src/support/lowlevel/firehub.PHP.php 7.27% 51 Missing ⚠️
src/kernel/http/firehub.Server.php 0.00% 30 Missing ⚠️
src/support/bags/firehub.RequestHeaders.php 0.00% 30 Missing ⚠️
src/initializers/enums/firehub.Kernel.php 0.00% 28 Missing ⚠️
src/components/di/firehub.ServiceManager.php 0.00% 23 Missing ⚠️
... and 43 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##             develop-pre-alpha      #91       +/-   ##
========================================================
- Coverage                67.91%   57.06%   -10.86%     
- Complexity                3027     3813      +786     
========================================================
  Files                      144      190       +46     
  Lines                     5143     6451     +1308     
========================================================
+ Hits                      3493     3681      +188     
- Misses                    1650     2770     +1120     
Files with missing lines Coverage Δ
...omponents/di/helpers/firehub.ContextualBinding.php 0.00% <ø> (ø)
src/components/firehub.Registry.php 88.88% <100.00%> (-11.12%) ⬇️
...c/support/collection/helpers/firehub.Condition.php 100.00% <100.00%> (ø)
...t/collection/helpers/firehub.CountCollectables.php 100.00% <100.00%> (ø)
...upport/collection/traits/firehub.Conditionable.php 100.00% <ø> (ø)
src/support/collection/type/firehub.Arr.php 98.94% <ø> (-0.34%) ⬇️
...rc/support/collection/type/firehub.Associative.php 99.46% <ø> (-0.10%) ⬇️
...rc/support/collection/type/firehub.ReadonlyArr.php 100.00% <100.00%> (ø)
...ort/collection/type/traits/firehub.Associative.php 100.00% <100.00%> (ø)
src/support/console/firehub.Input.php 100.00% <100.00%> (ø)
... and 59 more

... and 15 files with indirect coverage changes

Impacted file tree graph

@dieselxxx dieselxxx linked an issue Sep 24, 2024 that may be closed by this pull request
2 tasks
public function testCall ():void {

$this->container->bind(
Str::class, fn(Container $container):object => new Str('test')

Check warning

Code scanning / PHPMD

Unused Code Rules: UnusedFormalParameter Warning test

Avoid unused parameters such as '$container'.
@dieselxxx dieselxxx linked an issue Sep 25, 2024 that may be closed by this pull request
1 task
@dieselxxx dieselxxx linked an issue Sep 26, 2024 that may be closed by this pull request
2 tasks
@dieselxxx dieselxxx linked an issue Oct 28, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: FireHub Core Core platform label. priority: Normal Normal priority issues or pull requests. scope: Other Issues or pull requests for undefined scope. status: Draft This issue or pull request in draft mode. type: Development Internel development pull request that usually contain large updates.
Projects
Status: Draft
2 participants