Implement Dimensional DataGenerator #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Aether codebase is still in the middle of porting so the DataGen content is stale with 1.17 syntax. The first commit gets this out of the way. In this process however, I needed to comment out the loottables so they wouldn't crash
runData. Jaryt is fine with this.The second commit is the key stuff: I wrote Twilight Forest a Registry-compliant Codec DataGenerator that'll delegate potentially inlined content into distinct files instead. This PR implements essentially the same thing.
The dimension object in the code is fleshed out with some example-y filler stuff to get the world-recreation process underway. I've also renamed a bunch of generalized names into distinct names as well for easier differentiation when looking at logged errors.
I've renamed the preexisting non-generated biome
.jsontodefunct.jsonto read for the original content configuration when porting that toAetherBiomeProvider#makeDefaultBiome(). Currently features are broken big-time these will need to be fixed first before adding to the biome.