Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Aether models can be transparent #1299

Merged
merged 2 commits into from
May 6, 2023
Merged

fix: Aether models can be transparent #1299

merged 2 commits into from
May 6, 2023

Conversation

bconlon1
Copy link
Contributor

@bconlon1 bconlon1 commented May 5, 2023

closes #1273

@bconlon1 bconlon1 added the status/pending-review The issue references a pull request which is pending review. label May 5, 2023
@bconlon1 bconlon1 self-assigned this May 5, 2023
@OzPayn
Copy link
Contributor

OzPayn commented May 6, 2023

image
Looks good but Valkyrie wings are ignoring transparency

@OzPayn
Copy link
Contributor

OzPayn commented May 6, 2023

image
good but now they dont render for spectators lmao

OzPayn
OzPayn approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@OzPayn OzPayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out the wings thing is consistent so looks good!

@OzPayn OzPayn merged commit 9471a83 into 1.19.4-develop May 6, 2023
@OzPayn OzPayn deleted the feat/bconlon/spectator-fix branch May 6, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OzPayn OzPayn OzPayn approved these changes

Assignees

@bconlon1 bconlon1

Labels
status/pending-review The issue references a pull request which is pending review.
Projects
The Aether
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Some entities are poorly rendered when they are invisible and the player is in spectator mode
2 participants
@bconlon1 @OzPayn