Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spawn cost values to more hostile mobs #1285

Merged
merged 14 commits into from
May 6, 2023

Conversation

OzPayn
Copy link
Contributor

@OzPayn OzPayn commented May 3, 2023

added spawn costs to Cockatrices and Swets, adjusted cost values to try and get things feeling good, requires testing and feedback

closes #1199
closes #1266

added spawn costs to Cockatrices and Swets, adjusted cost values to try and get things feeling good, requires testing and feedback
@OzPayn OzPayn self-assigned this May 3, 2023
@OzPayn OzPayn added the status/in-progress The issue is currently being worked on. label May 3, 2023
Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aechor plants are too common

Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aechor plants need their rates slightly decreased
swets need their rates slightly increased

aechor plants should be slightly rarer
Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aechor plants and swets seem good but now zephyrs and aerwhales are a bit nonexistent

OzPayn and others added 3 commits May 4, 2023 18:31
aerwhales and zephyrs should populate more reliably
primarily accounting for/using the new zephyr spawn behaviour
Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aechor plants, swets, and aerwhales are good. zephyrs still kind of nonexistent. cockatrice rates could maybe be slightly greater too for under areas and night.

@OzPayn OzPayn marked this pull request as ready for review May 5, 2023 16:47
@OzPayn OzPayn added status/pending-review The issue references a pull request which is pending review. and removed status/in-progress The issue is currently being worked on. labels May 5, 2023
@bconlon1 bconlon1 self-requested a review May 6, 2023 02:27
Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OzPayn OzPayn merged commit a640b64 into 1.19.4-develop May 6, 2023
@OzPayn OzPayn deleted the feat/oz/spawn-cost-experiment branch May 6, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/pending-review The issue references a pull request which is pending review.
Projects
Archived in project
2 participants