Skip to content

Conversation

@GP4cK
Copy link
Contributor

@GP4cK GP4cK commented Jun 15, 2021

  1. Added eslint to viewer/
  2. Linted files in viewer/src/
  3. Added github action to lint viewer/src

@GP4cK
Copy link
Contributor Author

GP4cK commented Jun 16, 2021

The linter fails because I didn't fix all the linting errors. You can see what these errors are if you click on Details on the right.
We have a couple of options to manage this:

  1. Fix the errors by refactoring the code
  2. Ignore and merge like this
  3. Adjust the linting rules in viewer.eslintrc.js

Let me know what you prefer.

Note: for future PR, the linter should only run on the files modified by the PR author

@agviegas agviegas merged commit 5c6d1f4 into ThatOpen:master Jun 16, 2021
@GP4cK GP4cK deleted the setup-eslint branch June 16, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants