Skip to content

Specify colors as sRGB-Rec709-D65 for color management #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Specify colors as sRGB-Rec709-D65 for color management #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web-ifc-three/src/IFC/components/IFCParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,10 @@ export class IFCParser implements ParserAPI {
return;
}

const col = new Color(color.x, color.y, color.z);
// Assume RGB components are in sRGB-Rec709-D65 colorspace, and specify
// this so three.js can convert if THREE.ColorManagement APIs are enabled.
// TODO: https://github.com/three-types/three-ts-types/issues/342
const col = new Color().setRGB(color.x, color.y, color.z, 'srgb');
const material = new MeshLambertMaterial({ color: col, side: DoubleSide });
material.transparent = color.w !== 1;
if (material.transparent) material.opacity = color.w;
Expand Down