fix package manager detection in dash shell#63
Merged
ThatOneCalculator merged 1 commit intoJun 5, 2025
Conversation
POSIX does not require that `command` accept more than one parameter. Because `dash` silently ignores additional parameters, replacement of `which` with `command -v` resulted in `dash` (which is the default `/bin/sh` on Debian and Ubuntu) ignoring all package managers except nix-env (the first one on the list).
Contributor
Author
Owner
|
Thank you! Will be making a new release with this + #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX does not require that
commandaccept more than one parameter. Becausedashsilently ignores additional parameters, replacement ofwhichwithcommand -vresulted indash(which is the default/bin/shon Debian and Ubuntu) ignoring all package managers exceptnix-env(the first one on the list).This PR resolves the issue by using a
forloop aroundcommand -v, which should work in any POSIX shell.hyperfineshows this to be just as fast as the previous code, keeping the speedup from droppingwhich.Reference: https://pubs.opengroup.org/onlinepubs/009696899/utilities/command.html
Resolves: #59