Skip to content

Reduce usage of std::time_t, std::chrono::system_clock::to_time_t and system_clock::from_time_t in order to get correct dates when working with a 32bit application #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce usage of std::time_t, std::chrono::system_clock::to_time_t and system_clock::from_time_t in order to get correct dates when working with a 32bit application #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/jwt-cpp/jwt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2610,7 +2610,8 @@ namespace jwt {

JWT_CLAIM_EXPLICIT basic_claim(typename json_traits::string_type s) : val(std::move(s)) {}
JWT_CLAIM_EXPLICIT basic_claim(const date& d)
: val(typename json_traits::integer_type(std::chrono::system_clock::to_time_t(d))) {}
: val(typename json_traits::integer_type(
std::chrono::duration_cast<std::chrono::seconds>(d.time_since_epoch()).count())) {}
JWT_CLAIM_EXPLICIT basic_claim(typename json_traits::array_type a) : val(std::move(a)) {}
JWT_CLAIM_EXPLICIT basic_claim(typename json_traits::value_type v) : val(std::move(v)) {}
JWT_CLAIM_EXPLICIT basic_claim(const set_t& s) : val(typename json_traits::array_type(s.begin(), s.end())) {}
Expand Down Expand Up @@ -2659,9 +2660,8 @@ namespace jwt {
*/
date as_date() const {
using std::chrono::system_clock;
if (get_type() == json::type::number)
return system_clock::from_time_t(static_cast<std::time_t>(std::round(as_number())));
return system_clock::from_time_t(static_cast<std::time_t>(as_integer()));
if (get_type() == json::type::number) return date(std::chrono::seconds(std::llround(as_number())));
return date(std::chrono::seconds(as_integer()));
}

/**
Expand Down
Loading