Skip to content

Improve as_date narrowing conversion from C4244 warning #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Improve as_date narrowing conversion from C4244 warning #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/jwt-cpp/jwt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2625,15 +2625,15 @@ namespace jwt {
/**
* \brief Get the contained JSON value as a date
*
* If the value is a decimal, it is rounded up to the closest integer
* If the value is a decimal, it is rounded to the closest integer
*
* \return content as date
* \throw std::bad_cast Content was not a date
*/
date as_date() const {
using std::chrono::system_clock;
if (get_type() == json::type::number) return system_clock::from_time_t(std::round(as_number()));
return system_clock::from_time_t(as_integer());
if (get_type() == json::type::number) return system_clock::from_time_t(static_cast<std::time_t>(std::round(as_number())));
return system_clock::from_time_t(static_cast<std::time_t>(as_integer()));
}

/**
Expand Down
Loading