Add support for CMake Presets #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows ran in debug, which means the multi config needs more help
https://learn.microsoft.com/en-us/cpp/build/cmake-presets-vs?view=msvc-170 "You can set C and C++ compilers by using cacheVariables.CMAKE_C_COMPILER and cacheVariables.CMAKE_CXX_COMPILER in a Configure Preset. It's equivalent to passing -D CMAKE_C_COMPILER=<value> and -D CMAKE_CXX_COMPILER=<value> to CMake from the command line."
more quotes for inputs
Thalhammer
approved these changes
May 29, 2024
Owner
Thalhammer
left a comment
Thalhammer
left a comment
There was a problem hiding this comment.
Just some minor comments, otherwise good to merge from my side.
| mkdir build | ||
| cd build | ||
| cmake .. -DJWT_BUILD_EXAMPLES=ON -DJWT_BUILD_TESTS=ON | ||
| sudo make install |
Owner
There was a problem hiding this comment.
Is there a reason for the explicit make vs a cmake --build . --target install ?
Collaborator
Author
There was a problem hiding this comment.
most of the are make install but there's no reason... it should really be cmake --install . for the ones not using presets
I dont remember why, it looks like it was debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to move some of the setup and configuration variables from the CI scripts to the build configurations to make it easier to run them locally. This is most evident when it comes to the sanitizers and fuzzers but also for the examples.
The second benefit is also from #344 is to make the cross platform tests the same. The intention will be to have all the three OS just run the exact same steps.
As a bonus, I've added a few recommended extensions for VS Code so anyone who might want to contribute will be off on the right foot (hopefully)