fix: thumbnails preview stayed the same when playing next video, by changing video url and setting up vtt thumbnails #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urosZoretic
changed the title
urosZoretic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: thumbnails preview stayed the same when playing next video, by changing video url and setting up vtt thumbnails
when source url in video.js player is changed and player already exists. calling
vttThumbnails({...})setup again will cause plugin to create multiplethumbnail-previewdiv containers. As consequence plugin can end up creating multiple containers for different video url sources, but it will show only first one created..With this fix I have resolve issued to firstly remove old one if it exists and then plugin can create new one as normal. This resolve issue when playing next video in a sequence by changing video url and setting up thumbnails again, but thumbnails stayed the same
I have created PR from my fork, because I am not allowed to push into dev branch
related issues: #16