Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compiler flag for layout spec categories #11

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Add compiler flag for layout spec categories #11

merged 1 commit into from
Mar 7, 2019

Conversation

maicki
Copy link

@maicki maicki commented Jan 4, 2019 •
edited
Loading

By default the flag is enabled to retain default behavior.

@maicki maicki requested a review from nguyenhuy January 4, 2019 07:51
@maicki maicki force-pushed the MSLayoutSpecFlag branch from 3e34fda to f90ec77 Compare March 7, 2019 17:33
@maicki maicki force-pushed the MSLayoutSpecFlag branch from f90ec77 to 0b6615c Compare March 7, 2019 17:41
@maicki
Copy link
Author

maicki commented Mar 7, 2019

@nguyenhuy Could you please give that a look. Thanks!

nguyenhuy
nguyenhuy approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay.

@maicki maicki merged commit 10092ba into master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maicki @nguyenhuy