Tags: TextureGroup/Texture
Tags
Fix: Transfer leadingScreensForBatching from pending state on node lo… …ad (#2130) * Fix: Transfer leadingScreensForBatching from pending state on node load and add tests * Address PR comments * try to fix build * Adding whitespace to see if builds run * Revert prev commit to check if builds are working --------- Co-authored-by: Gianmarco <gfolchi@pinterest.com>
Fix: Transfer leadingScreensForBatching from pending state on node lo… …ad (#2130) * Fix: Transfer leadingScreensForBatching from pending state on node load and add tests * Address PR comments * try to fix build * Adding whitespace to see if builds run * Revert prev commit to check if builds are working --------- Co-authored-by: Gianmarco <gfolchi@pinterest.com>
Fix: Transfer leadingScreensForBatching from pending state on node lo… …ad (#2130) * Fix: Transfer leadingScreensForBatching from pending state on node load and add tests * Address PR comments * try to fix build * Adding whitespace to see if builds run * Revert prev commit to check if builds are working --------- Co-authored-by: Gianmarco <gfolchi@pinterest.com>
Fix: Transfer leadingScreensForBatching from pending state on node lo… …ad (#2130) * Fix: Transfer leadingScreensForBatching from pending state on node load and add tests * Address PR comments * try to fix build * Adding whitespace to see if builds run * Revert prev commit to check if builds are working --------- Co-authored-by: Gianmarco <gfolchi@pinterest.com>
Fix: Transfer leadingScreensForBatching from pending state on node lo… …ad (#2130) * Fix: Transfer leadingScreensForBatching from pending state on node load and add tests * Address PR comments * try to fix build * Adding whitespace to see if builds run * Revert prev commit to check if builds are working --------- Co-authored-by: Gianmarco <gfolchi@pinterest.com>
Fix: Transfer leadingScreensForBatching from pending state on node lo… …ad (#2130) * Fix: Transfer leadingScreensForBatching from pending state on node load and add tests * Address PR comments * try to fix build * Adding whitespace to see if builds run * Revert prev commit to check if builds are working --------- Co-authored-by: Gianmarco <gfolchi@pinterest.com>
Add default image provider (#2127) * Add default image provider ## Summary Right now image nodes hardcode logic to use either PINRemoteImage or the basic image downloader. Additionally, Texture is missing annotations for nullability and sendable for several of the image blocks and types. Introduce ASDefaultImageDownloader as a singleton. It takes blocks to return the default image downloader and image cache. Update both image nodes to use this. By default ASDefaultImageDownloader uses the same logic the image nodes used to, so change in behavior. ## Test plan Run the Kittens example and verify it works. * Appears we need Xcode 16.4 * And need at least 18.5
Add default image provider (#2127) * Add default image provider ## Summary Right now image nodes hardcode logic to use either PINRemoteImage or the basic image downloader. Additionally, Texture is missing annotations for nullability and sendable for several of the image blocks and types. Introduce ASDefaultImageDownloader as a singleton. It takes blocks to return the default image downloader and image cache. Update both image nodes to use this. By default ASDefaultImageDownloader uses the same logic the image nodes used to, so change in behavior. ## Test plan Run the Kittens example and verify it works. * Appears we need Xcode 16.4 * And need at least 18.5
Add default image provider (#2127) * Add default image provider ## Summary Right now image nodes hardcode logic to use either PINRemoteImage or the basic image downloader. Additionally, Texture is missing annotations for nullability and sendable for several of the image blocks and types. Introduce ASDefaultImageDownloader as a singleton. It takes blocks to return the default image downloader and image cache. Update both image nodes to use this. By default ASDefaultImageDownloader uses the same logic the image nodes used to, so change in behavior. ## Test plan Run the Kittens example and verify it works. * Appears we need Xcode 16.4 * And need at least 18.5
Add default image provider (#2127) * Add default image provider ## Summary Right now image nodes hardcode logic to use either PINRemoteImage or the basic image downloader. Additionally, Texture is missing annotations for nullability and sendable for several of the image blocks and types. Introduce ASDefaultImageDownloader as a singleton. It takes blocks to return the default image downloader and image cache. Update both image nodes to use this. By default ASDefaultImageDownloader uses the same logic the image nodes used to, so change in behavior. ## Test plan Run the Kittens example and verify it works. * Appears we need Xcode 16.4 * And need at least 18.5
PreviousNext