Match interfacestate update sequence to uikit #882
Conversation
Source/ASCollectionView.mm
Outdated
| // Exit CellNodes first before Collection to match UIKit behaviors (tear down bottom up). | ||
| // Although we have not yet cleared the interfaceState's Visible bit (this happens in __exitHierarchy), | ||
| // the ASRangeController will get the correct value from -interfaceStateForRangeController:. | ||
| [_rangeController updateRanges]; |
There was a problem hiding this comment.
Normally visible cells will exit first before collection in UIKit;
This change is to ask cells in preload/visible state to exit "together" with visible ones (before collection exit)
| @@ -376,7 +380,7 @@ - (void)_updateVisibleNodeIndexPaths | |||
| [newVisibleNodes addObject:node]; | |||
| } | |||
| // Skip the many method calls of the recursive operation if the top level cell node already has the right interfaceState. | |||
| if (node.interfaceState != interfaceState) { | |||
| if (node.pendingInterfaceState != interfaceState) { | |||
There was a problem hiding this comment.
This will make sure the correct interface exiting order when thrashing happen during push animation (node being pushed will exit - enter - exit hierarchy).
Note the first exit & enter happened in one runloop triggered by CAAnimation inside UIKit.
Before the change: node will exit for first exit call instead of last. End up visible cell node exit, collection exit, other cell node in preload/display exit.
After the change: Collection exit, cell in visible/preload/display exits
Generated by 🚫 Danger |
For example of CollectionNode of Red, Green, Blue cells exit by pushing a new viewController on top of it.
(each cell is of UIScreen's size)
Before
2018-04-17 14:51:12.035338-0700 Sample[57499:4071071] !!! preCommit
2018-04-17 14:51:12.035596-0700 Sample[57499:4071071] ^^^^ Red didExitVisibleState <ICCellNode: 0x7ff54481aa00>
2018-04-17 14:51:12.035730-0700 Sample[57499:4071071] ^^^^ didExitDisplayState <ICCollectionNode: 0x7ff542500250>
2018-04-17 14:51:12.041084-0700 Sample[57499:4071071] ^^^^ didExitVisibleState <ICCollectionNode: 0x7ff542500250>
2018-04-17 14:51:12.041251-0700 Sample[57499:4071071] ^^^^ Green didExitDisplayState <ICCellNode: 0x7ff544006000>
2018-04-17 14:51:12.041375-0700 Sample[57499:4071071] ^^^^ Blue didExitPreloadState <ICCellNode: 0x7ff544004400>
2018-04-17 14:51:12.041708-0700 Sample[57499:4071071] !!! postCommit
Afters
2018-04-17 14:44:54.097780-0700 Sample[57279:4016006] !!! preCommit
2018-04-17 14:44:54.098054-0700 Sample[57279:4016006] ^^^^ Red didExitVisibleState <ICCellNode: 0x7fed0a821200>
2018-04-17 14:44:54.098174-0700 Sample[57279:4016006] ^^^^ Green didExitDisplayState <ICCellNode: 0x7fed0a019a00>
2018-04-17 14:44:54.098333-0700 Sample[57279:4016006] ^^^^ Blue didExitPreloadState <ICCellNode: 0x7fed0d807600>
2018-04-17 14:44:54.098464-0700 Sample[57279:4016006] ^^^^ didExitDisplayState <ICCollectionNode: 0x7fed09d039c0>
2018-04-17 14:44:54.098596-0700 Sample[57279:4016006] ^^^^ didExitVisibleState <ICCollectionNode: 0x7fed09d039c0>