Fix capturing self in the block while loading image in ASNetworkImageNode #777
Conversation
Source/ASNetworkImageNode.mm
Outdated
| if (strongSelf == nil) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I believe this code should stay – we want to "re-strongify" when we reach the main thread.
There was a problem hiding this comment.
I can't understand you intention for doing such thing because strongSelf is already captured and can't pass away
There was a problem hiding this comment.
strongSelf will be released at the end of the ASPerformBlockOnBackgroundThread block, which may happen before the main thread services our ASPerformBlockOnMainThread call.
There was a problem hiding this comment.
So its imporrant that the main thread block not capture strongSelf, and instead capture weakSelf and then attempt to retain it
There was a problem hiding this comment.
Thanks for explanation. I’ve understood your intention. I supposed that it isn’t critical to capture strongSelf in this case because there are only delegate calls inside the block. I will revert my change
|
@morozkin If you'll add an entry to the changelog, we'll be ready to merge this. |
…Node (#777) * Fix capturing self in the block while loading image in ASNetworkImageNode * Restore re-strongify while switching on the main thread * Update CHANGELOG.md
…Node (TextureGroup#777) * Fix capturing self in the block while loading image in ASNetworkImageNode * Restore re-strongify while switching on the main thread * Update CHANGELOG.md
No description provided.