Fix synchronous state of node if +viewClass or +layerClass is overwritten #trivial #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
requested changes
Jan 30, 2018
Source/ASDisplayNode.mm
Outdated
| _layerClass = [self.class layerClass]; | ||
|
|
There was a problem hiding this comment.
I think we should do the same for +layerClass, in case the node is layer-backed.
maicki
changed the title
nguyenhuy
approved these changes
Jan 30, 2018
maicki
force-pushed
the
MSFixSynchronousStateOfNodeIfViewClassOverwritten
branch
from
a1546c5
to
f164f2b
Compare
maicki
force-pushed
the
MSFixSynchronousStateOfNodeIfViewClassOverwritten
branch
from
f164f2b
to
7339fbf
Compare
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…tten #trivial (TextureGroup#776) * Fix synchronous state of node if +viewClass is overwritten * Also check for _layerClass overwrite for synchronous flag * Update some code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.