Skip to content

Conversation

garrettmoon
Copy link
Member

Found a dumb deadlock thanks to @djblake

@ghost
Copy link

ghost commented Sep 25, 2017

🚫 CI failed with log

Copy link
Member

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would do it! This looks correct.

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyenhuy nguyenhuy merged commit 6c00897 into master Sep 27, 2017
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…up#582)

* Use node lock instead of separate one to avoid deadlocks.

* Add CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants