Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __has_include check in ASLog.h #trivial #55

Merged
merged 3 commits into from
Apr 22, 2017

Conversation

fsmorygo
Copy link
Contributor

@nguyenhuy recreating pull request as you asked

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2017

CLA assistant check
All committers have signed the CLA.

@garrettmoon
Copy link
Member

@fsmorygo do you mind adding a line to the CHANGELOG? Don't worry about the headers for now, we're going to fix them later.

@fsmorygo
Copy link
Contributor Author

@garrettmoon yeah sure. However the fix should be #trivial afaiu. What shall i do?

Add proper copyright in comment for ASLog.h
@garrettmoon garrettmoon changed the title Fix __has_include check in ASLog.h Fix __has_include check in ASLog.h #trivial Apr 22, 2017
@garrettmoon
Copy link
Member

@fsmorygo put #trivial in the title :D

@garrettmoon
Copy link
Member

(I'm working to improve our CI system, thanks for being a guinea pig)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants