Improvements in ASCollectionGalleryLayoutDelegate #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It now can handle section inset, as well as interitem and line spacings - Other small changes
|
🚫 CI failed with log |
garrettmoon
approved these changes
Aug 7, 2017
| self = [super init]; | ||
| if (self) { | ||
| // Scrollable directions must be either vertical or horizontal and can't be both | ||
| ASDisplayNodeAssertFalse(ASScrollDirectionContainsVerticalDirection(scrollableDirections) |
There was a problem hiding this comment.
Should we assert that it has at least one scrollable direction?
There was a problem hiding this comment.
Good point. I'll add it. Thanks for the review.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Improvements in ASCollectionGalleryLayoutDelegate - It now can handle section inset, as well as interitem and line spacings - Other small changes * Fix build failure and update file licenses * Update CHANGELOG * Minor change * Another assertion on scrollable directions of gallery layout delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASCollectionGalleryLayoutDelegatenow can handle section inset, as well as interitem and line spacings (thanks to [ASStackLayoutSpec] Flex wrap fix and lineSpacing property #472).