Add new workspaces for tests for different integrations #trivial #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
commented
Jun 21, 2017
| target 'ASDKListKitTests' do | ||
| pod 'Texture/IGListKit', :path => '..' | ||
| pod 'IGListKit', :git => 'https://github.com/Instagram/IGListKit', :commit => '357a28e' | ||
| pod 'JGMethodSwizzler', :git => 'https://github.com/JonasGessner/JGMethodSwizzler', :branch => 'master' |
There was a problem hiding this comment.
Moved to SubspecWorkspaces/ASDKListKit/Podfile
Adlai-Holler
commented
Jun 21, 2017
| require 'fileutils' | ||
| #TODO CocoaPods plugin instead? | ||
| post_install do |installer| | ||
| require 'fileutils' |
There was a problem hiding this comment.
Since the post_install hook isn't associated with the target (i.e. you can only have one per file,) moved this to root.
Adlai-Holler
commented
Jun 21, 2017
| debugDescription = [node debugDescription]; | ||
| dispatch_group_leave(g); | ||
| }]; | ||
| }); |
There was a problem hiding this comment.
detachNewThreadWithBlock: is iOS10-only. I don't suspect we'll run our tests against iOS 8/9 too too much, but this was the only divergence so let's keep the option open.
Adlai-Holler
commented
Jun 21, 2017
|
|
||
| #import <XCTest/XCTestAssertionsImpl.h> | ||
|
|
||
| #define ASXCTAssertEqualSizes(s0, s1, ...) \ |
There was a problem hiding this comment.
File was duplicated before. Now it, and all other Common test files, are referenced by the Subspec workspaces but stored in a common place.
Adlai-Holler
force-pushed
the
AHSubspecTests
branch
from
886a0ac
to
6253acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first chunk of work toward having tests for the upcoming Diffing subspec. We need to have a (relatively) scalable way to add unit tests that apply to Texture+Integration environments.