Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yoga] Delete YOGA_TREE_CONTIGOUS gating and permanently enable. #trivial #370

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

appleguy
Copy link
Member

NOTE: Yoga support is still highly experimental and is not
planned to become a supported / documented mode of the framework.
We recommend that most apps use ASStackLayoutSpec and the other
specs: http://texturegroup.org/docs/layout2-layoutspec-types.html

This reduces complexity of the Yoga integration points, and is
a first step towards further minimization and formalization of
the Yoga footprint in the framework.

NOTE: Yoga support is still highly experimental and is not
planned to become a supported / documented mode of the framework.
We recommend that most apps use ASStackLayoutSpec and the other
specs: http://texturegroup.org/docs/layout2-layoutspec-types.html

This reduces complexity of the Yoga integration points, and is
a first step towards further minimization and formalization of
the Yoga footprint in the framework.
@appleguy appleguy self-assigned this Jun 18, 2017
@ghost
Copy link

ghost commented Jun 18, 2017

🚫 CI failed with log

@appleguy
Copy link
Member Author

@garrettmoon is there a comment I can post that triggers a build re-run? This appears to be a spurious failure:

  testThatMultipleBatchFetchesDontHappenUnnecessarily, failed - Too many batch fetches!
  /Users/Shared/buildkite/builds/iosf-garrett-VMrmmvuqKsO4.dyn.pinadmin.com-1/pinterest/texture/Tests/ASCollectionViewTests.mm:891
if (batchFetchCount > 1) {
  XCTFail(@"Too many batch fetches!");
  return;


   Executed 452 tests, with 1 failure (0 unexpected) in 23.750 (24.213) seconds
Failing tests:
  -[ASCollectionViewTests testThatMultipleBatchFetchesDontHappenUnnecessarily]
** TEST FAILED **

@ghost
Copy link

ghost commented Jun 18, 2017

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@appleguy appleguy changed the title [Yoga] Delete YOGA_TREE_CONTIGOUS gating and permanently enable. [Yoga] Delete YOGA_TREE_CONTIGOUS gating and permanently enable. #trivial Jun 19, 2017
@appleguy appleguy merged commit 8c33a61 into master Jun 19, 2017
@appleguy appleguy deleted the YogaContiguousForever branch June 19, 2017 01:19
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…tureGroup#370)

[Yoga] Delete YOGA_TREE_CONTIGOUS gating and permanently enable. #trivial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants