Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first-pass view model support to collection node. #trivial #356

Merged
merged 4 commits into from
Jun 12, 2017
Merged

Add first-pass view model support to collection node. #trivial #356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5fc459
Add first-pass view model support for collection node. Much more to c…
Adlai-Holler Jun 12, 2017
51aa5f8
Address issues
Adlai-Holler Jun 12, 2017
60ab65e
Update the gorram license header
Adlai-Holler Jun 12, 2017
ff590b6
Dear lord
Adlai-Holler Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address issues
  • Loading branch information
@Adlai-Holler
Adlai-Holler committed Jun 12, 2017
commit 51aa5f87b715cc18285c9a22aa5b771fc9e62621
2 changes: 1 addition & 1 deletion Source/ASCellNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ typedef NS_ENUM(NSUInteger, ASCellNodeVisibilityEvent) {
*
* The view-model currently assigned to this node, if any.
*
* This property may be set off the main thread, but it will never be set in parallel.
* This property may be set off the main thread, but this method will never be invoked concurrently on the
*/
@property (atomic, nullable) id viewModel;

Expand Down
2 changes: 1 addition & 1 deletion examples/CatDealsCollectionView/Sample/ItemNode.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ - (instancetype)initWithViewModel:(ItemViewModel *)viewModel
{
self = [super init];
if (self != nil) {
_viewModel = viewModel;
self.viewModel = viewModel;
[self setup];
[self updateLabels];
[self updateBackgroundColor];
Expand Down